Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Allow for composite action distributions in PPO/A2C losses #2391

Merged
merged 19 commits into from
Sep 4, 2024

added required grad for td

69922fa
Select commit
Loading
Failed to load commit list.
Merged

[BugFix] Allow for composite action distributions in PPO/A2C losses #2391

added required grad for td
69922fa
Select commit
Loading
Failed to load commit list.
PyTorch Bot / Dr.CI completed Aug 27, 2024 in 0s

Dr.CI classification results

{"FAILED":[{"workflowId":10562401919,"workflowUniqueId":82165822,"id":29312211578,"runnerName":"i-0b616191869fccc86","authorEmail":"albertbou92@gmail.com","name":"Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job","jobName":"tests-olddeps (3.8, 11.6) / linux-job","conclusion":"failure","completed_at":"2024-08-27T14:23:12Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401919/job/29312211578","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":["test/test_transforms.py::TestKLRewardTransform::test_kl_lstm"],"failure_lines":["FAILED test/test_transforms.py::TestKLRewardTransform::test_kl_lstm - AttributeError: module 'torch' has no attribute 'compiler'"],"failure_context":["+ bash .github/unittest/linux_olddeps/scripts_gym_0_13/batch_scripts.sh","+ bash .github/unittest/linux_olddeps/scripts_gym_0_13/setup_env.sh","+ TD_GET_DEFAULTS_TO_NONE=1","+ export TD_GET_DEFAULTS_TO_NONE=1","+ TF_CPP_MIN_LOG_LEVEL=0","+ export TF_CPP_MIN_LOG_LEVEL=0","+ TORCH_VERSION=nightly","+ export TORCH_VERSION=nightly","+ RELEASE=0","+ export RELEASE=0","+ [[ refs/pull/2391/merge =~ release/* ]]","+ TAR_OPTIONS=--no-same-owner"],"time":"2024-08-27T14:23:28.991765Z"},{"workflowId":10562401914,"workflowUniqueId":60501564,"id":29312199749,"runnerName":"i-045fa8bf6543526cb","authorEmail":"albertbou92@gmail.com","name":"Habitat Tests on Linux / tests (3.9, 12.1) / linux-job","jobName":"tests (3.9, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-08-27T14:02:38Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401914/job/29312199749","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":["RuntimeError: Command docker exec -t f23d7a0d50375b8b6643e0be9fd98c75aaca18bffb65563fbc745b18c9ea0e5b /exec failed with exit code 139"],"failure_lines":["RuntimeError: Command docker exec -t f23d7a0d50375b8b6643e0be9fd98c75aaca18bffb65563fbc745b18c9ea0e5b /exec failed with exit code 139"],"failure_context":["+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/run_test.sh","+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/install.sh","+ bash /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/setup_env.sh","+ cp /pytorch/rl/.github/unittest/linux_libs/scripts_habitat/10_nvidia.json /usr/share/glvnd/egl_vendor.d/10_nvidia.json","+ this_dir=/pytorch/rl/.github/unittest/linux_libs/scripts_habitat","++ pwd","++ cd .github/unittest/linux_libs/scripts_habitat","+++ dirname .github/unittest/linux_libs/scripts_habitat/run_all.sh","+ apt-get dist-upgrade -y","+ apt-get install -y g++ gcc","+ apt-get install -y libglvnd0 libgl1 libglx0 libegl1 libgles2","+ apt-get install -y libglfw3 libgl1-mesa-glx libosmesa6 libglew-dev"],"time":"2024-08-27T14:02:41.951009Z"},{"workflowId":10562401959,"workflowUniqueId":82165821,"id":29312216283,"runnerName":"i-0299cf3b02505a442","authorEmail":"albertbou92@gmail.com","name":"Libs Tests on Linux / unittests-gym (3.9, 12.1) / linux-job","jobName":"unittests-gym (3.9, 12.1) / linux-job","conclusion":"failure","completed_at":"2024-08-27T14:02:15Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401959/job/29312216283","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":["test/test_libs.py::TestCollectorLib::test_collector_run[device0-GymEnv-env_args0-env_kwargs0]"],"failure_lines":["FAILED test/test_libs.py::TestCollectorLib::test_collector_run[device0-GymEnv-env_args0-env_kwargs0] - AttributeError: module 'torch' has no attribute 'compiler'"],"failure_context":["+ ./.github/unittest/linux_libs/scripts_gym/batch_scripts.sh","+ ./.github/unittest/linux_libs/scripts_gym/setup_env.sh","+ TD_GET_DEFAULTS_TO_NONE=1","+ export TD_GET_DEFAULTS_TO_NONE=1","+ BATCHED_PIPE_TIMEOUT=60","+ export BATCHED_PIPE_TIMEOUT=60","+ TAR_OPTIONS=--no-same-owner","+ export TAR_OPTIONS=--no-same-owner","+ LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu:/usr/lib/i386-linux-gnu:/usr/local/nvidia/lib:/usr/local/nvidia/lib64:/usr/local/nvidia/lib:/usr/local/nvidia/lib64:/work/mujoco-py/mujoco_py/binaries/linux/mujoco210/bin","+ export LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu:/usr/lib/i386-linux-gnu:/usr/local/nvidia/lib:/usr/local/nvidia/lib64:/usr/local/nvidia/lib:/usr/local/nvidia/lib64:/work/mujoco-py/mujoco_py/binaries/linux/mujoco210/bin","+ CU_VERSION=11.4","+ export CU_VERSION=11.4"],"time":"2024-08-27T14:02:22.525244Z"}],"FLAKY":[{"workflowId":10562401942,"workflowUniqueId":106193614,"id":29314479920,"runnerName":"GitHub Actions 69","authorEmail":"albertbou92@gmail.com","name":"Build Windows Wheels / pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cpu","jobName":"pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cpu","conclusion":"failure","completed_at":"2024-08-27T14:30:25Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401942/job/29314479920","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":null,"failure_lines":null,"failure_context":null,"time":"2024-08-27T14:30:30.798648Z"},{"workflowId":10562401942,"workflowUniqueId":106193614,"id":29314480485,"runnerName":"GitHub Actions 65","authorEmail":"albertbou92@gmail.com","name":"Build Windows Wheels / pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda11_8","jobName":"pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda11_8","conclusion":"failure","completed_at":"2024-08-27T14:30:30Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401942/job/29314480485","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":null,"failure_lines":null,"failure_context":null,"time":"2024-08-27T14:30:34.268956Z"},{"workflowId":10562401942,"workflowUniqueId":106193614,"id":29314481050,"runnerName":"GitHub Actions 120","authorEmail":"albertbou92@gmail.com","name":"Build Windows Wheels / pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda12_1","jobName":"pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda12_1","conclusion":"failure","completed_at":"2024-08-27T14:30:26Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401942/job/29314481050","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":null,"failure_lines":null,"failure_context":null,"time":"2024-08-27T14:30:35.298029Z"},{"workflowId":10562401942,"workflowUniqueId":106193614,"id":29314481535,"runnerName":"GitHub Actions 284","authorEmail":"albertbou92@gmail.com","name":"Build Windows Wheels / pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda12_4","jobName":"pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda12_4","conclusion":"failure","completed_at":"2024-08-27T14:30:22Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401942/job/29314481535","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":null,"failure_lines":null,"failure_context":null,"time":"2024-08-27T14:30:26.799236Z"},{"workflowId":10562401903,"workflowUniqueId":61790681,"id":29312196125,"runnerName":"GitHub Actions 9","authorEmail":"albertbou92@gmail.com","name":"Continuous Benchmark (PR) / CPU Pytest benchmark","jobName":"CPU Pytest benchmark","conclusion":"failure","completed_at":"2024-08-27T13:59:49Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401903/job/29312196125","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":null,"failure_lines":null,"failure_context":null,"time":"2024-08-27T13:59:54.600752Z"},{"workflowId":10562401903,"workflowUniqueId":61790681,"id":29312196867,"runnerName":"i-0cab60c0fad329a27","authorEmail":"albertbou92@gmail.com","name":"Continuous Benchmark (PR) / GPU Pytest benchmark","jobName":"GPU Pytest benchmark","conclusion":"failure","completed_at":"2024-08-27T14:04:51Z","html_url":"https://github.com/pytorch/rl/actions/runs/10562401903/job/29312196867","head_branch":"loss_composite_dist","pr_number":2391,"head_sha":"69922faadc6b8a1aa0864fa2c5d6577716b788c6","head_sha_timestamp":"2024-08-26T15:14:32Z","failure_captures":null,"failure_lines":null,"failure_context":null,"time":"2024-08-27T14:04:57.271620Z"}],"BROKEN_TRUNK":[],"UNSTABLE":[]}