Skip to content

Commit

Permalink
[CI] Fix windows build legacy
Browse files Browse the repository at this point in the history 
ghstack-source-id: 5931159572a19a8c25ce774d050d2054cdbabae5
Pull Request resolved: #2450
  • Loading branch information
@vmoens
vmoens committed Sep 23, 2024
1 parent e294c68 commit 33e86c5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-wheels-windows.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
post-script: "python packaging/wheel/relocate.py"
smoke-test-script: test/smoke_test.py
package-name: torchrl
name: pytorch/rl
name: ${{ matrix.repository }}
uses: pytorch/test-infra/.github/workflows/build_wheels_windows.yml@main
with:
repository: ${{ matrix.repository }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/wheels-legacy.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python_version: [["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
python_version: [["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
steps:
- name: Setup Python
uses: actions/setup-python@v2
Expand All @@ -37,12 +37,12 @@ jobs:
python3 -mpip install wheel
TORCHRL_BUILD_VERSION=0.5.0 python3 setup.py bdist_wheel
- name: Upload wheel for the test-wheel job
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: torchrl-win-${{ matrix.python_version[0] }}.whl
path: dist/torchrl-*.whl
- name: Upload wheel for download
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: torchrl-batch.whl
path: dist/*.whl
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
run: |
python3 -mpip install numpy pytest pytest-cov codecov unittest-xml-reporting pillow>=4.1.1 scipy av networkx expecttest pyyaml
- name: Download built wheels
uses: actions/download-artifact@v2
uses: actions/download-artifact@v3
with:
name: torchrl-win-${{ matrix.python_version }}.whl
path: wheels
Expand Down

2 comments on commit 33e86c5

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'CPU Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 33e86c5 Previous: e294c68 Ratio
benchmarks/test_replaybuffer_benchmark.py::test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 33.3579024069561 iter/sec (stddev: 0.1789589080229842) 230.3935588300763 iter/sec (stddev: 0.0005901943677496244) 6.91

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vmoens

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'GPU Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 33e86c5 Previous: e294c68 Ratio
benchmarks/test_replaybuffer_benchmark.py::test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 680.2794235481773 iter/sec (stddev: 0.03487034025251961) 2466.860446664261 iter/sec (stddev: 0.00004488292724894078) 3.63

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vmoens

Please sign in to comment.