Remove accidental Fiona dependency #1979
Conversation
|
I don't really understand, these changes have already been merged? See 8bc6b02, this is a commit to the main branch, so these changes are already there. I'd expect a PR that removes that line in requirements. Or a PR that reverts that commit, then adds only the wanted changes. |
|
@Conengmo I am getting mixed signals here. You say you do not understand, but from your suggestions I get the impression you do. Maybe I over interpret this, but I am left wondering if I did something that you are unhappy about. |
hansthen
force-pushed
the
realtime_type_changes
branch
from
244a136
to
e2ee004
Compare
|
Sorry if I’ve given offense! I didn’t mean to. I’m really a bit confused :) when I look at the ‘files changed’ I see changes that I think are already in the main branch. If I’m not mistaken 8bc6b02 is that commit that adds these changes to the main branch. So what is this PR supposed to do? I don’t mean that in a bad way, just trying to understand. Is there some git weirdness going on here? |
No offence taken; sometimes it is hard to communicate via text fields. I made the change your requested on the already merged branch. However, I forgot to sync against the main repo first. I should have rebased it first or started from a clean branch. |
hansthen
force-pushed
the
realtime_type_changes
branch
from
e2ee004
to
aebbf02
Compare
|
That makes sense! Thanks for clarifying and for updating the branch. |
|
I don’t know why that test failed but this can just be merged I suppose. |
Undo adding fiona to requirements.