Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly requires fiona for testing #1978

Closed

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jun 17, 2024

Fixes the failures we are seeing in #1976 due to geopandas changes.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 17, 2024

Looks like we have a problem with the packages on Windows.

Importing fiona resulted in: DLL load failed while importing _env: The specified module could not be found.

@martinfleis
Copy link
Collaborator

Coming from conda-forge/minizip-feedstock#17

@ocefpaf
Copy link
Member Author

ocefpaf commented Jun 17, 2024

This PR is no longer needed b/c the root of the problem was not the lack of fiona but a bad Windows library in the dependency chain. That was resolved upstream. Closing this one.

@ocefpaf ocefpaf closed this Jun 17, 2024
@ocefpaf ocefpaf deleted the explicitly_requires_fiona branch June 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants