Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move fixture finalizing to pytest_fixture_teardown hook #12164

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ShurikMen
Copy link
Contributor

solution #12163

@ShurikMen ShurikMen changed the title add track exception in pytest_fixture_post_finalizer hook move fixture finalizing to pytest_fixture_teardown hook Mar 27, 2024
@rplevka
Copy link

rplevka commented Apr 10, 2024

I was just about to submit a PR with almost identical code changes when I discovered yours :)
Changes are looking great, but I think you want to append the new-hook reference to the docs here

@rplevka
Copy link

rplevka commented Apr 19, 2024

that failing test does not seem to be related to the contributed code

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, how does this interact with pytest-asyncio?

@ShurikMen
Copy link
Contributor Author

this looks good to me, how does this interact with pytest-asyncio?

For pytest-asyncio, everything should work without additional improvements

@bluetech bluetech self-requested a review April 24, 2024 13:00
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking "Request changes" as per my comment on the issue: #12163 (comment)

@ShurikMen @rplevka please let me know in the issue if you have any specific use case for pytest_fixture_teardown instead of extending pytest_fixture_post_finalizer

@ShurikMen
Copy link
Contributor Author

Marking "Request changes" as per my comment on the issue: #12163 (comment)

@ShurikMen @rplevka please let me know in the issue if you have any specific use case for pytest_fixture_teardown instead of extending pytest_fixture_post_finalizer

I use it like this #12163 (comment)

@ogajduse
Copy link

@bluetech Can the community be of any help to help to push this PR forward? The discussion in #12163 seems to be waiting for your response.

@rplevka
Copy link

rplevka commented Sep 30, 2024

@RonnyPfannschmidt help, please? I think this has been stale for some time. We think the change makes perfect sense and we would really find it useful in our project.
Thank you.

@RonnyPfannschmidt
Copy link
Member

im also waiting for a reply from @bluetech - i think the concerns mentioned need to be addressed

@ogajduse
Copy link

ogajduse commented Oct 3, 2024

@RonnyPfannschmidt Are there any concerns that should be addressed by the community? If so, could you please let us know what are these? I believe that concerns @bluetech had were answered in #12163.
It is already 5 months since this has been open. I would like to know whether there is any chance merging it or we should be looking into a completely different approach or a place to put the logic in.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants