server_facts: Switch from legacy to structured facts #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still testing this, but feedback is already welcome. |
|
voxpupuli/puppet-example#65 looks good to me |
ekohl
approved these changes
Aug 3, 2024
david22swan
approved these changes
Aug 9, 2024
|
Thank you @bastelfreak :-) Merging. |
|
Reading back on this, I'm wonder if we should revert this because it doesn't reflect reality. This code is to reflect what happens in puppetserver: |
|
I think it makes more sense to update puppetserver: puppetlabs/puppetserver#2878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structured facts are around since some years and the legacy facts are deprecated. The current releases causes a lot of
Could not retrieve fact ipaddresswarnings during CI run.