Call the correct ResponseError method #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the agent failed to download it's client cert leading to an Puppet::HTTP:ReponseError exception, then it tried to call a nonexistent `message` method on the Puppet::HTTP::Response. Instead call `message` directly on the ResponseError, which contains the HTTP reason, e.g. Internal Server Error. Also when renewing a client cert, explicitly call e.message instead of relying on whatever ResponseError#to_s returns.
AriaXLi
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the agent failed to download it's client cert leading to an Puppet::HTTP:ReponseError exception, then it tried to call a nonexistent
messagemethod on the Puppet::HTTP::Response.Instead call
messagedirectly on the ResponseError, which contains the HTTP reason, e.g. Internal Server Error.Also when renewing a client cert, explicitly call e.message instead of relying on whatever ResponseError#to_s returns.