(maint) Remove needless check in setting default #9476
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line is not sane for the setting of the log_level default
loglevel = %x{ #{puppet_path} config --section agent --log_level notice print log_level }.chomp
this sets log_level to notice, and then return the output of the log_level setting
loglevel = "notice"
is the same thing with fewer steps
joshcooper
force-pushed
the
MartyEwings-patch-1
branch
from
9c01787
to
3ae3815
Compare
|
See #8958 (comment) for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line is not sane for the setting of the log_level default (because specifying
--log_levelon the command line always takes precedence over what's specified in puppet.conf)It sets log_level to notice, and then return the output of the log_level setting
is the same thing with fewer steps
Author: Marty Ewings martyewings@gmail.com
Supersedes PR #8958