Clarify soft limit on number of facts #9458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vchepkov I saw that you'd previously brought this to our attention in Slack, does this language read more clearly to you? |
Puppet warns when the total number of fact values exceeds a soft limit, as PuppetDB performance can start to degrade as that number grows. However, the language that Puppet currently uses to talk about this limit can be ambiguous. We want to emphasize that the total number of fact values--counting all children of all facts (every value in all arrays, hashes, etc.)--is what is relevant to performance. This commit adds more explicit language about what this number is counting.
mhashizume
force-pushed
the
PUP-12062/main/fact-limit
branch
from
d2df1eb
to
f7dfc72
Compare
joshcooper
approved these changes
Aug 29, 2024
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet warns when the total number of fact values exceeds a soft limit, as PuppetDB performance can start to degrade as that number grows.
However, the language that Puppet currently uses to talk about this limit can be ambiguous. We want to emphasize that the total number of fact values--counting all children of all facts (every value in all arrays, hashes, etc.)--is what is relevant to performance.
This commit adds more explicit language about what this number is counting.