(PUP-11928) Give more specific error messages for /puppet/v3/tasks API #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error message before my change: Error message after my change: |
AriaXLi
force-pushed
the
PUP-11928/puppet/v3/tasks_API_error_messages
branch
from
020ea1f
to
bfdf5b1
Compare
Currently, when a task is omitted due to a failure, Puppet Server logs an exception with a generic error message and provides no details on how to resolve the error: `ERROR [qtp1527520408-905] [puppetserver] Puppet Failed to validate task` This commit removes the generic message that overrides the original error message in the rescued error. Instead, the rescued error message is logged.
AriaXLi
force-pushed
the
PUP-11928/puppet/v3/tasks_API_error_messages
branch
from
bfdf5b1
to
3973318
Compare
joshcooper
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a task is omitted due to a failure, Puppet Server logs an exception with a generic error message and provides no details on how to resolve the error:
ERROR [qtp1527520408-905] [puppetserver] Puppet Failed to validate taskThis commit removes the generic message that overrides the original error message in the rescued error. Instead, the rescued error message is logged.