(PUP-11934) Use String#each_codepoint instead of deprecated String#codepoints #9103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does |
|
No, but it prints a deprecation message to the log when it's called. In MRI that usage was marked as deprecated in a previous version of Ruby and the documentation for it has been removed: https://ruby-doc.org/3.2.2/String.html#method-i-codepoints |
|
@justinstoller will this need to target 7.x too? We think we're testing against 9.3 there, but we weren't sure if it issues the same deprecation warning? |
|
It can target 7.x, but it's only problematic in 8.x. (at least so far) JRuby started warning in 9.4.3 not 9.3.x. I don't know if they plan to backport that warning. Lemme know if you'd like it cherrypicked. |
justinstoller
force-pushed
the
bug/maint/PUP-11934_deprecated_codepoints_usage
branch
from
18dffcc
to
dc95e7f
Compare
|
Rebased onto 7.x |
|
Closing and reopening to rekick checks |
joshcooper
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.