(PUP-11856) State machine renews host cert #9075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
reviewed
Jun 26, 2023
mhashizume
force-pushed
the
PUP-11856/main/state-machine-renew
branch
2 times, most recently
from
de3d44e
to
86b02e7
Compare
joshcooper
reviewed
Jun 27, 2023
joshcooper
reviewed
Jun 27, 2023
joshcooper
reviewed
Jun 27, 2023
joshcooper
reviewed
Jun 27, 2023
joshcooper
reviewed
Jun 27, 2023
joshcooper
reviewed
Jun 27, 2023
mhashizume
force-pushed
the
PUP-11856/main/state-machine-renew
branch
3 times, most recently
from
823cfbf
to
c317f95
Compare
joshcooper
reviewed
Jun 27, 2023
mhashizume
force-pushed
the
PUP-11856/main/state-machine-renew
branch
from
c317f95
to
5396d4e
Compare
joshcooper
reviewed
Jun 27, 2023
mhashizume
force-pushed
the
PUP-11856/main/state-machine-renew
branch
from
5396d4e
to
1a50213
Compare
joshcooper
approved these changes
Jun 27, 2023
This commit adds a new NeedRenewedCert class and related logic to the state machine to handle automatic host/client certificate renewal.
Previously, the build_cert method in Puppet::TestCa needed special logic for the Eliptical Curve class: ruby/openssl#29 This issue was resolved in OpenSSL 2.0, which was released in 2016, meaning that all versions of Ruby that Puppet supports includes Ruby/OpenSSL >= 2.0. This commit removes special logic for EC in Puppet::TestCa.
This commit does three things: - Update the CA library to enable resuing an SSL private key when generating a certificate; - Enable the certificate generating Rake task to generate a new "renewed" certificate to support testing automatic certificate renewal; - Regenerate all of the SSL test fixtures using that Rake task.
mhashizume
force-pushed
the
PUP-11856/main/state-machine-renew
branch
from
1a50213
to
c5370df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new NeedRenewedCert class and related logic to the state machine to handle automatic host/client certificate renewal.