(maint) Simplifies SSLContext intialization #9073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
force-pushed
the
maint/7.x/keyword-struct
branch
2 times, most recently
from
4836dd0
to
e84c6c0
Compare
mhashizume
force-pushed
the
maint/7.x/keyword-struct
branch
3 times, most recently
from
d1f9e70
to
0a561ee
Compare
Ruby 2.5 added the `keyword_init: true` option to Struct.new to enable keyword arguments. This commit updates the Puppet::SSL::SSLContext to take advantage of this language feature and removes a workaround needed for older versions of Ruby. Additionally, Ruby 3.2 addeed the ability to initialize a Struct with keyword arguments without the `keyword_init: true` option. This commit adds a comment noting that, so it can be removed in the future when Puppet drops support for Ruby < 3.2.
mhashizume
force-pushed
the
maint/7.x/keyword-struct
branch
from
0a561ee
to
aa41b45
Compare
joshcooper
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.5 added the
keyword_init: trueoption to Struct.new to enable keyword arguments.This commit updates the Puppet::SSL::SSLContext to take advantage of this language feature and removes a workaround needed for older versions of Ruby.
Additionally, Ruby 3.2 addeed the ability to initialize a Struct with keyword arguments without the
keyword_init: trueoption. This commit adds a comment noting that, so it can be removed in the future when Puppet drops support for Ruby < 3.2.