Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minitar rubygem on AIX #863

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

joshcooper
Copy link
Contributor

@joshcooper joshcooper commented Jun 18, 2024

The puppet module install command assumes tar is GNUtar, which doesn't
work on AIX. Install minitar on AIX like we do for Windows and Solaris.

This relates to puppetlabs/puppet#9387 (comment)

Built https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging_generic-builder/3018/BUILD_TARGET=aix-7.2-ppc,SLAVE_LABEL=k8s-worker/

14:19:04 export GEM_HOME="/opt/puppetlabs/puppet/lib/ruby/gems/3.2.0" && \
14:19:04 export GEM_PATH="/opt/puppetlabs/puppet/lib/ruby/gems/3.2.0" && \
14:19:04 export RUBYLIB="/opt/puppetlabs/puppet/lib/ruby/vendor_ruby:" && \
14:19:04 cd ./ && \
14:19:04 /opt/puppetlabs/puppet/bin/gem install --no-document --local minitar-0.9.gem
14:19:05 The `minitar` executable is no longer bundled with `minitar`. If you are
14:19:05 expecting this executable, make sure you also install `minitar-cli`.
14:19:05 Successfully installed minitar-0.9
14:19:05 1 gem installed

The rubygem-ffi component was added in the agent-runtime-<version> project for
all platforms and in the _shared-agent-components on Windows, etc. Just add it
always in the _shared-agent-components, which is also included by
_shared-pe-installer-runtime.

    $ git grep rubygem-ffi configs/projects/
    configs/projects/_pdk-components.rb:proj.component 'rubygem-ffi'
    configs/projects/_shared-agent-components.rb:proj.component 'rubygem-ffi'
    configs/projects/_shared-pe-bolt-server.rb:proj.component('rubygem-ffi')
    configs/projects/_shared-pe-bolt-server_with_ruby.rb:proj.component('rubygem-ffi')
    configs/projects/_shared-pe-installer-runtime.rb:proj.component('rubygem-ffi')
    configs/projects/bolt-runtime.rb:  proj.component 'rubygem-ffi'

The only project that doesn't add the ffi rubygem is client-tools-runtime-*
The puppet module install command assumes tar is GNUtar, which doesn't
work on AIX. Install minitar on AIX like we do for Windows and Solaris.
@joshcooper joshcooper added the enhancement New feature or request label Jun 18, 2024
@joshcooper joshcooper marked this pull request as ready for review June 20, 2024 22:02
@joshcooper joshcooper requested review from a team as code owners June 20, 2024 22:03
@mhashizume mhashizume merged commit 08c0261 into puppetlabs:master Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants