Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(packaging) PE-16465 Add windows and windowsfips to platform_repos #2344

Open
wants to merge 1 commit into
base: 7.x
Choose a base branch
from

Conversation

e-gris
Copy link
Contributor

@e-gris e-gris commented Apr 20, 2023

This adds the windows and windowsfips repos to the
puppet-agent-all.tar.gz tarball.

@e-gris e-gris requested a review from a team as a code owner April 20, 2023 19:38
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2023

CLA assistant check
All committers have signed the CLA.

@e-gris
Copy link
Contributor Author

e-gris commented Apr 20, 2023

Oops. Let me try that again.

@joshcooper
Copy link
Contributor

For posterity, the platform_repos hash is accessed in the packaging repo

which is called by the pl:jenkins:pack_all_signed_repos_individually rake task

And that task is called when performing an internal promotion and shipping to S3

Long term I think it would be preferable for this data to live in CJC, so that the list of platforms we build/test/tar can be versioned together, and it doesn't require a puppet-agent change if we forget to add a platform.

ext/build_defaults.yaml Outdated Show resolved Hide resolved
@joshcooper
Copy link
Contributor

@e-gris could you rebase your PR on upstream/7.x and squash the shrug commit?

@joshcooper
Copy link
Contributor

@e-gris sorry could you rebase (again)?

This adds the windows and windowsfips repos to the
puppet-agent-all.tar.gz tarball.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants