(CAT-2007) Use vendored cert files and VERIFY_PEER wth NET::HTTP on Windows #1396
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 127 127
Lines 5329 5329
=======================================
Hits 4716 4716
Misses 613 613 ☔ View full report in Codecov by Sentry. |
th3paradox007
approved these changes
Sep 18, 2024
david22swan
force-pushed
the
CAT-2007-2
branch
from
338eea3
to
c857683
Compare
danadoherty639
approved these changes
Sep 18, 2024
joshcooper
reviewed
Sep 20, 2024
| http.verify_mode = OpenSSL::SSL::VERIFY_NONE if Gem.win_platform? | ||
| if Gem.win_platform? | ||
| cert_path = 'C:/Program Files/Puppet Labs/DevelopmentKit\ssl\cert.pem' | ||
| http.cert = OpenSSL::X509::Certificate.new(cert_path) |
There was a problem hiding this comment.
@david22swan I think you want to call the ca_file= setter, passing the path to ca.pem file. The method you're calling is for the client cert which shouldn't be necessary for the pdk. See https://docs.ruby-lang.org/en/master/Net/HTTP.html#attribute-i-ca_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to successful test chain: https://jenkins-platform.delivery.puppetlabs.net/view/PDK/view/pdk-vanagon/job/platform_pdk_pdk-van-init_main/912/
Checklist