-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create upgrade labels when necessary #205
Comments
The same issue just blocked https://github.com/pulumi/pulumi-spotinst/actions/runs/6946256008/attempts/1. |
The urgency here is very low, since this was resolved upstream by pulumi/ci-mgmt#757. |
This issue makes https://github.com/pulumiverse/pulumi-acme/actions/runs/8778868034/job/24085996153#step:2:661 |
I'll take a look here. As with all of our partially internal tools, we need to create a clear distinction between what needs a pulumi specific setup and what should be usable in any repo. |
Instead of hard erroring, could we at least just warn that these labels don't exist but exit cleanly? Ideally, attempting to create them would be nice too though. |
@danielrbradley from your two options above, I would prefer to generate a warning. Attempting to create these labels could still error out if the user's Github token doesn't have permissions to create labels. |
Would this help instead ? pulumi/provider-version-action#13 |
Don't think so. The issue is just that if a third party repo hasn't set up the needs-release labels then the upgrade tool will always fail. That issue is interesting though, and I'd like to see it implemented 👍 |
Hello!
Issue details
When an upgrade is indicates,
upgrade-provider
needs to apply the label to trigger the upgrade on PR merge. Labels added areneeds-release/patch
,needs-release/minor
andneeds-release/major
.[^1] If label does not exist on the provider and needs to be created, the upgrade fails: https://github.com/pulumi/pulumi-rke/actions/runs/6935929271/attempts/1.We should solve this by:
upgrade-provider
.Affected area/feature
The text was updated successfully, but these errors were encountered: