Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create upgrade labels when necessary #205

Open
iwahbe opened this issue Nov 20, 2023 · 8 comments
Open

Create upgrade labels when necessary #205

iwahbe opened this issue Nov 20, 2023 · 8 comments
Labels
kind/enhancement Improvements or new features

Comments

@iwahbe
Copy link
Member

iwahbe commented Nov 20, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

When an upgrade is indicates, upgrade-provider needs to apply the label to trigger the upgrade on PR merge. Labels added are needs-release/patch, needs-release/minor and needs-release/major.[^1] If label does not exist on the provider and needs to be created, the upgrade fails: https://github.com/pulumi/pulumi-rke/actions/runs/6935929271/attempts/1.

We should solve this by:

  • Standardizing the list of provider labels and making sure the release labels are included, or
  • Creating the labels if they don't already exist within upgrade-provider.

Affected area/feature

@iwahbe iwahbe added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Nov 20, 2023
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Nov 21, 2023
@iwahbe
Copy link
Member Author

iwahbe commented Nov 21, 2023

@iwahbe
Copy link
Member Author

iwahbe commented Jan 3, 2024

The urgency here is very low, since this was resolved upstream by pulumi/ci-mgmt#757.

@ringods
Copy link
Member

ringods commented Apr 26, 2024

This issue makes upgrade-provider not usable outside of Pulumi.

https://github.com/pulumiverse/pulumi-acme/actions/runs/8778868034/job/24085996153#step:2:661

@iwahbe iwahbe self-assigned this Apr 26, 2024
@iwahbe
Copy link
Member Author

iwahbe commented Apr 26, 2024

I'll take a look here. As with all of our partially internal tools, we need to create a clear distinction between what needs a pulumi specific setup and what should be usable in any repo.

@danielrbradley
Copy link
Member

Instead of hard erroring, could we at least just warn that these labels don't exist but exit cleanly?

Ideally, attempting to create them would be nice too though.

@ringods
Copy link
Member

ringods commented Oct 1, 2024

@danielrbradley from your two options above, I would prefer to generate a warning. Attempting to create these labels could still error out if the user's Github token doesn't have permissions to create labels.

@iwahbe iwahbe removed their assignment Oct 1, 2024
@t0yv0
Copy link
Member

t0yv0 commented Oct 1, 2024

Would this help instead ? pulumi/provider-version-action#13

@danielrbradley
Copy link
Member

Would this help instead ? pulumi/provider-version-action#13

Don't think so. The issue is just that if a third party repo hasn't set up the needs-release labels then the upgrade tool will always fail.

That issue is interesting though, and I'd like to see it implemented 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

5 participants