Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-provider GitHub Actions workflow #19

Merged
merged 8 commits into from
May 22, 2024

Conversation

dustin-ruetz
Copy link
Contributor

@dustin-ruetz dustin-ruetz self-assigned this May 21, 2024
@dustin-ruetz dustin-ruetz requested a review from ringods May 21, 2024 20:28
Copy link

@ringods ringods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dustin-ruetz workflow is ok. However, I did encounter myself that your Github repo needs the issue/PR labels set which are listed in this issue:

pulumi/upgrade-provider#205

For this workflow not to fail, make sure you add these to this repo.

Copy link
Member

@edif2008 edif2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good pipeline to me based on the resources you've mentioned.

I've left 2 questions that don't block the PR from moving forward.

.github/workflows/upgrade-provider.yml Show resolved Hide resolved
.github/workflows/upgrade-provider.yml Outdated Show resolved Hide resolved
@dustin-ruetz dustin-ruetz merged commit 300e8be into main May 22, 2024
1 check passed
@dustin-ruetz dustin-ruetz deleted the ruetz-upgrade-provider-gha-workflow branch May 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants