Failing on vault

[t0yv0]

Noting that pulumi-vault is special legacy provider.

• cannot upgrade pulumi/pkg
• is forked (e.g. no upstream)

But it has a workflow to run upgrade-provider. It doesn't work though e.g.:

t0yv0@Antons-MacBook-Pro> ~/code/upgrade-provider/upgrade-provider  pulumi/pulumi-vault --kind provider                                                                                                                                                                                                                                               ~/code/pulumi-vault
---- Setting Up Environment ----
- ✓ GOWORK="off": done
- ✓ PULUMI_MISSING_DOCS_ERROR="true": done
- ✓ PULUMI_CONVERT_EXAMPLES_CACHE_DIR="": done
---- Discovering Repository ----
- Ensure 'github.com/pulumi/pulumi-vault'
  - ✓ Expected Location: /Users/t0yv0/code/pulumi-vault
  - ✓ Downloading: skipped - already exists
  - ✓ Validating: done
- pull default branch
  - ✓ /usr/bin/git ls-remote --heads origin: done
  - ✓ finding default branch: master
  - ✓ /usr/bin/git fetch: done
  - ✓ /usr/bin/git checkout master: done
  - ✓ /usr/bin/git pull origin: done
- ✓ Repo kind: forked
- ✓ Planning Provider Update: 3.20.0 -> 3.20.1
---- Upgrading Forked Provider ----
- Ensure 'github.com/hashicorp/terraform-provider-vault'
  - ✓ Expected Location: /Users/t0yv0/go/src/github.com/hashicorp/terraform-provider-vault
  - ✓ Downloading: skipped - already exists
  - ✓ Validating: done
- ✓ Ensure Pulumi Remote: 'pulumi' already exists
- ✓ /usr/bin/git fetch pulumi: done
- ✓ /usr/bin/git fetch origin --tags: done
- ✓ Discover Previous Upstream Version: 3.20.1
- X /usr/bin/git checkout pulumi/upstream-v3.20.1: exit status 1:
error: you need to resolve your current index first

Is upgrade-provider supposed to know how to deal with forked providers? If not:

• can it fail fast with a quick errmsg?
• and then let's maybe disable upgrade-provider workflow on vault

Should we instead convert vault to patched? Is that possible or blocked by other things it's stuck on.

[t0yv0]

I've performed an upgrade by hand for now and it's OK it seems.

[iwahbe]

Upgrade provider should know how to perform upgrades on forked providers, but since this is the only provider which is forked, that ability seems to have atrophied.