Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pulumi-vault from regular upgrade maintenance #602

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

guineveresaenger
Copy link
Contributor

Due to pulumi/pulumi-vault#197, pulumi-vault
cannot currently benefit from automation per this repository. Putting it
in a separate folder to await the resolution of the blocking issue and
avoid noise and spurious p1s caused by attempts to upgrade the bridge.

Upstream upgrades will continue to run automatically as per current
state of pulumi-vault's Workflow files.

Resolution for pulumi/pulumi-vault#310.

Due to pulumi/pulumi-vault#197, pulumi-vault
cannot currently benefit from automation per this repository. Putting it
in a separate folder to await the resolution of the blocking issue and
avoid noise and spurious p1s caused by attempts to upgrade the bridge.

Upstream upgrades will continue to run automatically as per current
state of pulumi-vault's Workflow files.
@guineveresaenger guineveresaenger requested review from t0yv0 and a team September 21, 2023 17:56
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulumi-vault can be maintained by this repos automation, just not for --kind=sdk,bridge updates.

It looks like this will prevent us from getting workflow updates which we still want AFAIK.

@t0yv0
Copy link
Member

t0yv0 commented Sep 21, 2023

That's true but that's what we kind of want also, because workflows will be moving on to wheel based publishing and so forth which requires Pulumi v3.80.0 or higher which Vault is currently unable to upgrade to.

Also note that upgrade-provvider currently not working either:
pulumi/upgrade-provider#162

Please reconsider - the is very little value to special case and do extra work for vault. When we are doing work for vault, I recommend (or volunteer) spending a day upgrading upstream to get on the newer azcore version and testing that out, then we can get back to completely normal state.

@iwahbe iwahbe self-requested a review September 21, 2023 19:28
@guineveresaenger guineveresaenger merged commit 0102829 into master Sep 21, 2023
1 check passed
@guineveresaenger guineveresaenger deleted the guin/handle-vault branch September 21, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants