Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output of default node group referring to autoscalingGroupName #1410

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Fix output of default node group referring to autoscalingGroupName #1410

merged 6 commits into from
Oct 1, 2024
+51 −46

Conversation

flostadler
Copy link
Contributor

@flostadler flostadler commented Sep 30, 2024 •
edited
Loading

In #1373 the default node group was updated to use the NodeGroupV2 component. We missed changing the NodeGroupData type to reflect this. It was still referring to a property called autoScalingGroupName, but it should've been changed to expose an autoScalingGroup.

Fixes #1402

@flostadler flostadler added the needs-release/major Marking a PR to compute the next major version label Sep 30, 2024
@flostadler flostadler requested review from t0yv0, corymhall and a team September 30, 2024 16:00
@flostadler flostadler self-assigned this Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Does the PR have any schema changes?

Found 3 breaking changes:

Types

  • "eks:index:NodeGroupData":
    • 🟡 properties: "autoScalingGroupName" missing
    • required:
      • 🟢 "autoScalingGroup" property has changed to Required
      • 🟢 "autoScalingGroupName" property is no longer Required
        No new resources/functions.

@t0yv0
Copy link
Member

t0yv0 commented Sep 30, 2024

Tests unhappy for some reason.

@flostadler
Copy link
Contributor Author

Tests unhappy for some reason.

Yeah, I miss-typed an output in the example. It's fixed now!

@flostadler flostadler merged commit dfd76f2 into release-3.x.x Oct 1, 2024
34 checks passed
@flostadler flostadler deleted the flostadler/fix-node-group-data branch October 1, 2024 16:29
@flostadler flostadler mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@corymhall corymhall Awaiting requested review from corymhall

Assignees

@flostadler flostadler

Labels
needs-release/major Marking a PR to compute the next major version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flostadler @t0yv0