Update go sdk v3 #1399
Merged
Update go sdk v3 #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Sep 26, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
reviewed
Sep 26, 2024
flostadler
approved these changes
Sep 26, 2024
t0yv0
added
the
needs-release/major
|
Version computation is not right per pulumi/provider-version-action#13 |
t0yv0
force-pushed
the
t0yv0/udpate-go-sdk-v3
branch
from
06798f8
to
a7768c9
Compare
|
Tagging this PR as needs-release/major has resulted in |
|
A tad better but tests need to be updated to point to V3 now. |
t0yv0
commented
Sep 26, 2024
| ) | ||
|
|
||
| replace github.com/pulumi/pulumi-eks/sdk/v3 => ../../../sdk |
There was a problem hiding this comment.
It would be good to avoid keeping the replaces but I can't seem to be able to run go mod tidy since there is no valid v3 SDK published yet. Trying replaces temporarily.
|
Go tests actually passed against the V3 SDK, that's good. |
|
I'm going to merge and cut another alpha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go SDK must be versioned as v3 otherwise Go refuses to use this.