Use correct token source for CLI auth #3606
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
danielrbradley
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Change looks simple enough. Perhaps we could add some explanation around these lines as to what the purpose is of each of these different auth variables. E.g. why is there both resourceManagerAuth and resourceManagerBearerAuth? What's the difference between auth and bearerAuth? Happy for this to be a follow-up though.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3606 +/- ##
==========================================
- Coverage 60.07% 59.83% -0.24%
==========================================
Files 69 69
Lines 8786 8786
==========================================
- Hits 5278 5257 -21
- Misses 3007 3037 +30
+ Partials 501 492 -9 ☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v2.64.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3603
Tested locally