Rewrite the validate_hif.py to use the new schema #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nwlandry FYI |
Would you like me to review? |
|
Yes, please take a look a the scripts/hif.py. It had a lot of duplication and many things seemed old. Thanks! |
|
Hi @colltoaction --- my only suggested change is to customize the output to improve the clarity of the error messages. Perhaps one way to handle this is to utilize the "messages" field. I think that @pszufe is best to review this PR, since he had an idea of what the output should be. |
|
Sounds good, thanks for taking a look. @pszufe I'm merging and we can continue this work on the main branch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if I deleted something I shouldn't have.