Fix several things that were broken in recent revisions. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the CodeMirror eclipse theme, and just use the default. This is the same default used in the PGProblemEditor for webwork2, and is actually very similar to the eclipse theme. If you don't like the dark theme, then we should just use the default. Increase the width of the sidebar to fit the content. Make the dropdown show the correct label when the macros page is selected. Remove the "default" tab pane and hidden sidebar item. The instructions that were in the tab pane simply aren't needed. This is a straightforward page with not much else to do. In addition the hidden list-group-item completely messes up the sidebar appearance. Remove the duplicate "parserFormulaUpToConstant.pl" key in macro_pod.yml, and add the missing "parserAutoStrings.pl" macro that is referenced in "doc/sample-problems/problem-techniques/StringsInContext.pg". Since this was not in the yml file, this caused a use of uninitialized value in string concatenation warning, and obviously the link didn't work. Also fix several issues with the documentation in the graph tool problems.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the CodeMirror eclipse theme, and just use the default. This is the same default used in the PGProblemEditor for webwork2, and is actually very similar to the eclipse theme. If you don't like the dark theme, then we should just use the default.
Increase the width of the sidebar to fit the content.
Make the dropdown show the correct label when the macros page is selected.
Remove the "default" tab pane and hidden sidebar item. The instructions that were in the tab pane simply aren't needed. This is a straightforward page with not much else to do. In addition the hidden list-group-item completely messes up the sidebar appearance.
Remove the duplicate "parserFormulaUpToConstant.pl" key in macro_pod.yml, and add the missing "parserAutoStrings.pl" macro that is referenced in "doc/sample-problems/problem-techniques/StringsInContext.pg". Since this was not in the yml file, this caused a use of uninitialized value in string concatenation warning, and obviously the link didn't work.
Also fix several issues with the documentation in the graph tool problems.