Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac #30

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix mac #30

merged 1 commit into from
May 23, 2024

Conversation

potuz
Copy link
Collaborator

@potuz potuz commented May 13, 2024

Fixes compilation on Mac OS X with newer ARM boards with clang.

Adds CI workflows for Mac OS X and Windows.

@potuz potuz force-pushed the fix_mac branch 9 times, most recently from d8c52b4 to 6bc39f2 Compare May 13, 2024 21:12
.github/workflows/test.yml Outdated Show resolved Hide resolved
src/Makefile Show resolved Hide resolved
src/sha256_armv8_neon_x4.S Show resolved Hide resolved
prestonvanloon
prestonvanloon previously approved these changes May 14, 2024
Copy link
Contributor

@arnetheduck arnetheduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! passes SSZ tests on our mac/arm64 runner

@matthewkeil
Copy link
Contributor

Sweet! Is working with our JS bindings on arm mac locally and in CI. You 🪨 dude!!

@potuz potuz merged commit 511d67f into main May 23, 2024
8 checks passed
potuz pushed a commit that referenced this pull request May 24, 2024
* nim: enable compilation on osx/clang

* mac only on arm64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants