optimisation: Simplify saving linearity correction #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep in mind that the EEPROM addresses are in descending order. This means we can't use eeprom_read_block() or eeprom_update_block() Address --> Axis 3831 --> X-axis 3830 --> Y-axis 3829 --> Z-axis 3828 --> E-axis Change in memory: Flash: -118 bytes SRAM: 0 bytes
|
All values in bytes. Δ Delta to base
|
leptun
reviewed
Sep 1, 2024
Change in memory: Flash: -22 bytes SRAM: 0 bytes
leptun
approved these changes
Sep 2, 2024
3d-gussner
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Tested with MK404 and behaves the same as before 👍
With DEBUG_EEPROM_CHANGES enabled
Test: Settings -> Lin. correction and change from XYZE all 0 to X 34 Y 33 Z 32 E 31
before
[2024-09-02 10:55:31.951287] RECV EEPROMChng b 3831 255 -> 34
[2024-09-02 10:55:31.953469] RECV EEPROMChng b 3830 255 -> 33
[2024-09-02 10:55:31.955096] RECV EEPROMChng b 3829 255 -> 32
[2024-09-02 10:55:31.956794] RECV EEPROMChng b 3828 255 -> 31
after factory reset and with this PR
[2024-09-02 11:09:35.037897] RECV EEPROMChng b 3831 255 -> 34
[2024-09-02 11:09:35.039573] RECV EEPROMChng b 3830 255 -> 33
[2024-09-02 11:09:35.041767] RECV EEPROMChng b 3829 255 -> 32
[2024-09-02 11:09:35.043484] RECV EEPROMChng b 3828 255 -> 31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this optimisation when cleaning up my fork. It looks like it's still relevant.
Keep in mind that the EEPROM addresses are in descending order. This means we can't use eeprom_read_block() or eeprom_update_block()
Address --> Axis
3831 --> X-axis
3830 --> Y-axis
3829 --> Z-axis
3828 --> E-axis
Change in memory:
Flash: -140 bytes
SRAM: 0 bytes