Abort nozzle change if filament is loaded #4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
sarusani
force-pushed
the
CheckFSBeforeNozzleChange
branch
from
d027c89
to
1d2407e
Compare
|
Currently I check for both original and revo nozzles. Is unloading required for a revo nozzle change or should I only check for original? |
gudnimg
reviewed
Aug 20, 2024
sarusani
force-pushed
the
CheckFSBeforeNozzleChange
branch
2 times, most recently
from
e6e3731
to
6f28608
Compare
Abort Nozzle change if fsensor is enabled and filament is present.
sarusani
force-pushed
the
CheckFSBeforeNozzleChange
branch
from
6f28608
to
64d9f20
Compare
3d-gussner
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Tested on MK404
- MK3S without filament loaded, behaves the same as before
- MK3S with filament loaded, shows Unload message and exits
- MK3S + MMU3 without filament loaded, behaves the same as before
- Mk3S + MMU3 with filament loaded, shows Unload message and exits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort Nozzle change if filament sensor is enabled and filament is loaded.
Resolves #4703