Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce _lcd_move() code size #4756

Closed
wants to merge 3 commits into from
Closed

Reduce _lcd_move() code size #4756

wants to merge 3 commits into from

Commits on Aug 24, 2024

  1. Reduce _lcd_move() code size 

    re-use clamp_to_software_endstops() to avoid code duplication

Change in memory:
Flash: -192 bytes
SRAM: 0 bytes
    @gudnimg
    gudnimg committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c92b80d View commit details
    Browse the repository at this point in the history

  2. Drop redundant lcd_draw_update assignment 

    lcd_draw_update is automatically set to 1 when the knob
is rotated. See lcd_knob_update()

_lcd_move is called before lcd_draw_update is decremented, since it is called as a submenu

Change in memory:
Flash: -12 bytes
SRAM: 0 bytes
    @gudnimg
    gudnimg committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    4750494 View commit details
    Browse the repository at this point in the history

  3. Make max_pos and min_pos static

    @gudnimg
    gudnimg committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c0904e4 View commit details
    Browse the repository at this point in the history