Remove legacy Auto Bed Leveling code #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
gudnimg
commented
Aug 9, 2024
| if (cs.add_homing[Z_AXIS] < 0) negative_z_offset = negative_z_offset + cs.add_homing[Z_AXIS]; | ||
| #endif | ||
| if (target[Z_AXIS] < min_pos[Z_AXIS]+negative_z_offset) target[Z_AXIS] = min_pos[Z_AXIS]+negative_z_offset; | ||
| if (target[Z_AXIS] < min_pos[Z_AXIS]) target[Z_AXIS] = min_pos[Z_AXIS]; |
There was a problem hiding this comment.
If you're wondering where 14 bytes of flash are saved. It is here, by removing negative_z_offset since it is always 0.
gudnimg
force-pushed
the
remove-auto-bed-leveling
branch
from
f2b3ff4
to
93d7e4b
Compare
The goal is to clean up the project
gudnimg
force-pushed
the
remove-auto-bed-leveling
branch
from
93d7e4b
to
2b1c49d
Compare
leptun
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed removing this code some time ago in 2021 (See #3227) and I want to propose again to remove auto bed leveling. The code has been unmaintained for many years and doesn't compile. This functionality has also not been tested / verified for many years.
The goal is to clean up the project so it's easier to maintain and further improve the project.