planner/stepper: simplify ultralcd.h
include into lcd.h
#4748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
UserECoolEnabled()
fromultralcd.cpp
intoeeprom.cpp
since this function has nothing to do with LCD specifically.To avoid including
Prusa_farm.h
intoepprom.cpp
, simply replacefarm_mode
variable by reading the farm mode from EEPROM directly. This change allows us to removeFarmOrUserECool()
function.The goal is to avoid including
ultralcd.h
in general since it is a nightmare to unit test as is. Includinglcd.h
is less of a problem thanultralcd.h
TODO:
SILENT_MODE_*
andTMC2130_MODE_*
preprocessor symbols. From EEPROM perspective these are the same.Something like this: