Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use M70 to set label for the filament to load at the M600 Insert filament screen #4731

Conversation

Panayiotis-git
Copy link
Contributor

A variation of the #4548. It repurposes the unused M70 command in the Prusa firmware to store a custom message, which is displayed by the M600 command on the load filament screen.

M70 Deep Blue
M600

The Insert filament screen will then show the custom text defined with the M70 command:

Insert filament
Deep Blue
and press the knob

Copy link

github-actions bot commented Jul 26, 2024

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 300 21 248122 5674 5830 2518
MK3_MULTILANG 302 21 247438 5683 6514 2509

Copy link
Collaborator

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for the PR. The only problem I see (at least on Github) is inconsistent indentation changes in the code. I commented on only two of them but there are more.

It could be a mix between spaces and tabs that makes the rendering different on Github.

Firmware/ultralcd.cpp Outdated Show resolved Hide resolved
Firmware/ultralcd.cpp Outdated Show resolved Hide resolved
@gudnimg gudnimg added this to the FW 3.14.1 milestone Jul 26, 2024
@gudnimg gudnimg requested a review from 3d-gussner July 26, 2024 20:32
@Panayiotis-git
Copy link
Contributor Author

Panayiotis-git commented Jul 26, 2024

Something is really off...

I will resubmit the PR.

@Panayiotis-git Panayiotis-git force-pushed the MK3_M600_Custom_loading_text_with_M70 branch from ac440cc to 497f932 Compare July 26, 2024 20:44
@gudnimg
Copy link
Collaborator

gudnimg commented Jul 26, 2024

Much better, thanks!

@gudnimg gudnimg self-requested a review July 26, 2024 20:50
Copy link
Collaborator

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I don’t see how it can go wrong. Should be tested on hardware though before merging, just in case.

@gudnimg
Copy link
Collaborator

gudnimg commented Jul 28, 2024

I tested this on my MK3S+ and I didn't find any way to break things :)

  • Sending only M70 shows no message ✔️
  • Sending M70 "Hello World" shows "Hello World" including the " characters ✔️ Exactly like M117
  • Running M600 the 2nd time (but not M70), no message is shown indicating it's reset properly. ✔️
  • Sending M70 with a very long string (more than 20 characters) is truncated correctly to the LCD line limit. ✔️

If no one objects to this PR, I would like to merge it.

@3d-gussner 3d-gussner removed this from the FW 3.14.1 milestone Aug 22, 2024
@3d-gussner
Copy link
Collaborator

Closing in favor of #4759

@3d-gussner 3d-gussner closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants