-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use M70 to set label for the filament to load at the M600 Insert filament screen #4731
Use M70 to set label for the filament to load at the M600 Insert filament screen #4731
Conversation
All values in bytes. Δ Delta to base
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi thanks for the PR. The only problem I see (at least on Github) is inconsistent indentation changes in the code. I commented on only two of them but there are more.
It could be a mix between spaces and tabs that makes the rendering different on Github.
Something is really off... I will resubmit the PR. |
ac440cc
to
497f932
Compare
Much better, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. I don’t see how it can go wrong. Should be tested on hardware though before merging, just in case.
I tested this on my MK3S+ and I didn't find any way to break things :)
If no one objects to this PR, I would like to merge it. |
Closing in favor of #4759 |
A variation of the #4548. It repurposes the unused M70 command in the Prusa firmware to store a custom message, which is displayed by the M600 command on the load filament screen.
The Insert filament screen will then show the custom text defined with the M70 command: