PFW-1559 Add filament presence check at start of print #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
leptun
reviewed
Jul 26, 2024
gudnimg
force-pushed
the
improve-missing-filament
branch
from
40193f2
to
d640764
Compare
|
The following videos demonstrate the changes more visually 😃 This video shows the default setting (Warning). I attempt to start a print with no filament loaded. This video shows the "Strict" setting. It will always cancel the print if filament is not loaded. |
leptun
approved these changes
Jul 28, 2024
gudnimg
changed the title
gudnimg
force-pushed
the
improve-missing-filament
branch
2 times, most recently
from
673e856
to
fb770cb
Compare
|
Synced the PR with latest MK3 branch. Also got rid of the "fixup" commit to make the history a bit cleaner. (No code has been changed) |
gudnimg
force-pushed
the
improve-missing-filament
branch
from
fb770cb
to
bf62679
Compare
|
Please do not merge this yet. I want to remove the mmu2.h include in utils.cpp. To make unit testing easier to begin with. To check if the MMU is enabled, I think it is ok to read the EEPROM value. The printer check shouldnt care if the MMU is communicating or not, it only cares if it is enabled at all. |
|
Should be ready for review again |
gudnimg
force-pushed
the
improve-missing-filament
branch
from
e2e2f4e
to
b873b7e
Compare
A new menu setting is added to configure how strict the check should be. - None: No check is performed - Warning (default): The user is warned about missing and is prompted to continue with Yes/No. If No is selected, the print is aborted. If no user input is given (e.g. from host printing) then the warning will expire in 30 seconds and assume the Yes option was selected - Strict: If the filament is not detected when a print is started, it is immediately canceled. The check is currently performed on G-codes: M24 and M75. Starting a SD print and Host print respectively.
This saves ~100B of flash
Change in memory: Flash: -54 bytes SRAM: 0 bytes
Pull all checks needed into the function such that the caller only needs to check the return value Also added description for the filament_presence_check function
gudnimg
force-pushed
the
improve-missing-filament
branch
from
ac81ec7
to
f5fe658
Compare
Configuration->HW Setup->Checks showed `a` MSG_FILAMENT `Filament` can only be 8 chars long and only ES and IT had `Filemanto` as translation. But as ES the `o` in `Filamento` was overwritten by `[Estricto]` I removed the MSG_FILAMENT to be translated. Saves few bytes.
Used `trans -b :cs+de+es+fr+hr+hu+it+nl+no+pl+ro+sk+sv "<text>"` to translate Looked at pre-translated text to reuse as much as possible.
3d-gussner
requested changes
Aug 26, 2024
Thanks to @petrubecheru and @Hauzman
Thanks to @stelgenhof
Thanks to @AttilaSVK
Thanks to @ingbrzy @shatter136
- Croatian, Swedish and Norwegian are inactive since the last few translation review requests have not been done
Fix LCD output and add translations
3d-gussner
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add filament presence check at start of print job. This PR aims to resolve issues where a user starts a print with no filament loaded. The idea is to use the M862 warning dialogs instead of relying on filament sensor runout. Relying on filament runout will require some fragile logic which may not be very reliable and risks adding new issues.
A new menu setting is added to configure how strict the check should be.
Yes/No. IfNois selected, the print is aborted. If no user input is given (e.g. from host printing) then the warning will expire in 30 seconds and the printer assumes theYesoption was selected.The check is currently performed on G-codes: M24 and M75. Starting a SD print and Host print respectively.