Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFW-1460 Update build scripts #4659

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

3d-gussner
Copy link
Collaborator

@3d-gussner 3d-gussner commented Apr 11, 2024

Builds all firmware.

Tested on

  • Linux (Ubuntu 20.04 LTS)
    • git clone
    • download zip
  • Windows 10
    • git clone
    • download zip

UPDATE 10 July:
It turns out that cmake on Windows and maybe also on MacOS has issues with wildcard usage, while Linux works fine.
Created #4708 to solve this issue.

@3d-gussner 3d-gussner added this to the FW 3.14.0 milestone Apr 11, 2024
@3d-gussner 3d-gussner changed the title PFW-1460 Add build.py PFW-1460 Update build scripts Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 0 0 247784 5653 6168 2539
MK3_MULTILANG 0 0 247082 5662 6870 2530

@3d-gussner 3d-gussner changed the title PFW-1460 Update build scripts :consPFW-1460 Update build scripts Apr 12, 2024
@3d-gussner 3d-gussner changed the title :consPFW-1460 Update build scripts 🚧 WIP: PFW-1460 Update build scripts Apr 12, 2024
@3d-gussner 3d-gussner modified the milestones: FW 3.14.0, FW 3.14.1 Apr 18, 2024
@3d-gussner 3d-gussner changed the title 🚧 WIP: PFW-1460 Update build scripts PFW-1460 Update build scripts Jul 5, 2024
@3d-gussner
Copy link
Collaborator Author

While testing Windows 10 the build.py script fails during compressing, while the Linux version is working correctly.
Looking into that.

@sarusani
Copy link
Contributor

sarusani commented Jul 5, 2024

The problem is not in the build.py. I get the same error when I run the "ALL_MULTILANG" CMake directly from VSCode. (Windows)

All multilang builds for MK25 & MK25S variants fail.
(English only builds work fine, so do all builds for MK3 & MK3S variants)

I'll have a closer look on the weekend.

@3d-gussner
Copy link
Collaborator Author

I think something goes wrong here on windows https://github.com/prusa3d/Prusa-Firmware/blob/MK3/CMakeLists.txt#L594-L595
Can you check on Windows if build\release\release is created which would be https://github.com/prusa3d/Prusa-Firmware/blob/MK3/CMakeLists.txt#L594

Or maybe it takes bit longer on Windows to create the directory and the next line is executed too early?

@sarusani
Copy link
Contributor

sarusani commented Jul 5, 2024

Windows doesn't like the ${variant_name}_${FN_VERSION_SUFFIX}_en*.hex.
The wildcard doesn't work. If you (just for testing) change it to ${variant_name}_${FN_VERSION_SUFFIX}_en-ro.hex the build works.

PS:
I think the problem is that in linux the filepath is resolved by the shell and then passed to cmake. In windows this doesn't seem to be the case...
(Not sure about this 😄)

@3d-gussner
Copy link
Collaborator Author

@sarusani Please try #4708 + this PR.

@3d-gussner 3d-gussner marked this pull request as ready for review July 11, 2024 07:02
@3d-gussner 3d-gussner requested a review from DRracer July 12, 2024 06:17
@3d-gussner 3d-gussner merged commit 39c8c4f into prusa3d:MK3 Jul 12, 2024
4 checks passed
@3d-gussner 3d-gussner deleted the MK3_build_script branch July 12, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants