🚧 Planner flag optimizations #4433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
gudnimg
reviewed
Oct 15, 2023
gudnimg
reviewed
Oct 15, 2023
| @@ -233,7 +235,7 @@ FORCE_INLINE block_t *plan_get_current_block() | |||
| return(NULL); | |||
| } | |||
| block_t *block = &block_buffer[block_buffer_tail]; | |||
| block->busy = true; | |||
There was a problem hiding this comment.
Note this is called in the Stepper ISR. Is it safe to drop the volatile keyword?
There was a problem hiding this comment.
I worry about race conditions here
There was a problem hiding this comment.
I think yes. I didn't see any place where volatile was really needed.
There was a problem hiding this comment.
Added @wavexx as reviewer, I think he would know best if this is OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined boolean variables in the planner struct with the "flag" variable