Fix FW_COMMIT_HASH compiler warning
#4432
Conversation
On my end, the default length for the abbreviated commit hash is 9 characters. This won't fit into uint32_t (4 bytes). Instead change FW_COMMIT_HASH into a string and create preprocessor symbol for the string length such that it's known at compile time. If the string should be longer or shorter then only FW_COMMIT_HASH_LENGTH needs to be configured on the CMake side
|
The function |
|
All values in bytes. Δ Delta to base
|
|
@vintagepc the last commit seems to have resolved the static assert :) There is still an issue with the Github Action. The runner doesn't detect I've tried to run the Workflow via Docker on Windows using https://github.com/nektos/act but no luck so far.
|
The command /usr/bin/git describe --abbrev=0 --dirty=-D --broken=-B Was returning error code 128 and no output. In the workflow file, specifying fetch-depth = 0, will make sure to fetch all branches and tags. This seems to fix the issue.
|
Fixed the issue with the git description command. The problem was not that git command wasn't found, our script is just interpreting the error that way :) |
|
We can shorten the hash to 8 chars with |
Note that I think having the data as a string ( |
|
Okay. Is the other comment resolved? |
Yeah 69e06ba resolved it. Github always failed to build before that fix because I added a new |
|
@vintagepc Can we merge it? |
On my end, the default length for the abbreviated commit hash is 9 characters and won't fit into
uint32_t.To fix this I propose to change
FW_COMMIT_HASHinto a string and create preprocessor symbol for the string length so that it's known at compile time.If the string should be longer or shorter then only
FW_COMMIT_HASH_LENGTHneeds to be configured on the CMake side