PFW-1525 Add Set Readymenu
#4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
gudnimg
reviewed
Oct 5, 2023
gudnimg
reviewed
Oct 5, 2023
DRracer
reviewed
Oct 13, 2023
DRracer
reviewed
Oct 13, 2023
DRracer
reviewed
Oct 13, 2023
3d-gussner
force-pushed
the
MK3_PFW-1525_Printer_Ready
branch
2 times, most recently
from
3eafd93
to
c03b011
Compare
DRracer
reviewed
Oct 27, 2023
DRracer
previously requested changes
Oct 27, 2023
gudnimg
reviewed
Nov 4, 2023
gudnimg
reviewed
Nov 4, 2023
gudnimg
reviewed
Nov 4, 2023
3d-gussner
force-pushed
the
MK3_PFW-1525_Printer_Ready
branch
from
c03b011
to
a65f8b1
Compare
|
@gudnimg please review again |
gudnimg
reviewed
Nov 19, 2023
gudnimg
reviewed
Nov 19, 2023
gudnimg
approved these changes
Nov 19, 2023
|
@3d-gussner Looking at the translation PR, it seems |
|
The state can be checked with M72 without parameters. |
3d-gussner
force-pushed
the
MK3_PFW-1525_Printer_Ready
branch
from
f4b3a9a
to
685bf14
Compare
13 tasks
DRracer
reviewed
Nov 22, 2023
| @@ -5191,7 +5206,13 @@ static void lcd_main_menu() | |||
| } else if (!Stopped) { | |||
| MENU_ITEM_SUBMENU_P(_i("Preheat"), lcd_preheat_menu);////MSG_PREHEAT c=18 | |||
| } | |||
|
|
|||
| if (GetPrinterState() < PrinterState::IsSDPrinting && M79_timer_get_status()) { | |||
There was a problem hiding this comment.
Based on this statement, the order / numerical values of PrinterState members is important. A big warning should be added to the structure so that no one tries to reorder the items arbitrarily.
…rial Host has to send back state with `M72 S1|0` to keep printer and host in sync Changed LCD menu messages to `Set ready` and `Set not ready` Updated translations
… LcdCommands::Idle;`
DRracer
requested changes
Nov 22, 2023
Add documentation Whitespace
3d-gussner
force-pushed
the
MK3_PFW-1525_Printer_Ready
branch
from
d11cf0c
to
02459ed
Compare
DRracer
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation in 2nd part to prevent conflicts with other PRs
Menu
Set ReadyShown
Hidden
When menu selected a serial message
// action:printer_readyis sent and Menu is hidden ✔️Set Readyvia gcodeM72 S[1|0]from PrusaConnect or PrusaLinkUpdate RepRap Wiki
M72