Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish translation update. #4411

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Polish translation update. #4411

merged 5 commits into from
Oct 13, 2023

Conversation

arekm
Copy link
Contributor

@arekm arekm commented Sep 26, 2023

PL diacritics and some unification. Lengths have changed in few cases.

druk - jako proces
wydruk - jako produkt
wyładuj (zamiast rozładuj)
kanał (nie slot)
katalog (nie folder)
podręcznik (nie instrukcja)
firmware (krótsze; nie oprogramowanie układowe)
bazowanie (nie zerowanie bo zerowanie może wiele rzeczy oznaczać)
nieudane (zamiast nie powiódł się bo krótsze)

@arekm
Copy link
Contributor Author

arekm commented Sep 26, 2023

Ok, so these "cols=20" comments are hard limits, right?

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Target ΔFlash (bytes) ΔSRAM (bytes)
MK3S_MULTILANG 0 0
MK3_MULTILANG 0 0

@3d-gussner
Copy link
Collaborator

Ok, so these "cols=20" comments are hard limits, right?

Yes the c=xx r=y are hard limits. You can use lang-check.py --information to show all messages and pages.
I used that for German as there it is allowed to split words with a - (German can have very very long words) to fit it better on one page.
Try to get everything on one page (20x4) and not to have only one word on next page. Sometimes \n is useful to force a new line but use this only if necessary.

@3d-gussner
Copy link
Collaborator

3d-gussner commented Sep 27, 2023

Here the output for the Polish translation.

polish_messages.txt

I will ask the internal Polish translator to review these changes.

Thanks a lot.

Sidenote: Vscode Polish spellchecker shows still lot of issues BUT a native speaking person should beat any spell checker.

@3d-gussner
Copy link
Collaborator

@arekm If you have translations with c=20 r>=5 and you get an error/warning it is not an big issue we can expand it, ONLY if really needed.

As each char costs at least two bytes of the resources. I limited the rows to the max used of all translations.
See it more as a warning that you exceed the limit other languages have been able to squeeze in the translations.

Real hard limits

  • c<20 are used in menus and selections and very limited. We need to get a toggle menu within a row
  • c=20
  • c=20 r=2 Messages with two row selections
  • c=20 r=3 Messages with last row selections
  • c=20 r=4 Some of these message are limited to one page only

@3d-gussner 3d-gussner added this to the FW 3.14.0 milestone Sep 27, 2023
@3d-gussner 3d-gussner self-assigned this Sep 27, 2023
lang/po/Firmware_pl.po Outdated Show resolved Hide resolved
@leptun
Copy link
Collaborator

leptun commented Sep 28, 2023

@3d-gussner Please ping me when this PR is merged since I want to rebase the diacritics PR after this is merged

@leptun
Copy link
Collaborator

leptun commented Sep 30, 2023

@3d-gussner Now that I think about it, I think it would be better if the diacritics PR was merged first, then we rebase this PR on top of the latest MK3 branch, test this PR again, then merge it. Does this sound good?

druk - jako proces
wydruk - jako produkt
wyładuj (zamiast rozładuj)
kanał (nie slot)
katalog (nie folder)
podręcznik (nie instrukcja)
firmware (krótsze; nie oprogramowanie układowe)
bazowanie (nie zerowanie bo zerowanie może wiele rzeczy oznaczać)
nieudane (zamiast nie powiódł się bo krótsze)
@leptun
Copy link
Collaborator

leptun commented Oct 3, 2023

Rebased and fixed the conflict

@3d-gussner 3d-gussner added the translations language packages label Oct 11, 2023
@3d-gussner 3d-gussner self-requested a review October 13, 2023 06:48
Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed internally and approved

@arekm Bardzo dziękuję za ten pull request

@3d-gussner 3d-gussner merged commit 3d7892f into prusa3d:MK3 Oct 13, 2023
5 checks passed
@3d-gussner
Copy link
Collaborator

@arekm See video #3383

@arekm
Copy link
Contributor Author

arekm commented Oct 19, 2023

Bed / hotend strings not marked as translatable at 3:28 ?

"Najpierw" twice at beginning of two sentences, one after another. Hmm, could change one occurrence to something else to not repeat it that often (3:13 and 3:17).

@3d-gussner 3d-gussner removed their assignment Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations language packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants