-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish translation update. #4411
Conversation
Ok, so these "cols=20" comments are hard limits, right? |
|
Yes the c=xx r=y are hard limits. You can use |
Here the output for the Polish translation. I will ask the internal Polish translator to review these changes. Thanks a lot. Sidenote: Vscode Polish spellchecker shows still lot of issues BUT a native speaking person should beat any spell checker. |
@arekm If you have translations with c=20 r>=5 and you get an error/warning it is not an big issue we can expand it, ONLY if really needed. As each char costs at least two bytes of the resources. I limited the rows to the max used of all translations. Real hard limits
|
@3d-gussner Please ping me when this PR is merged since I want to rebase the diacritics PR after this is merged |
@3d-gussner Now that I think about it, I think it would be better if the diacritics PR was merged first, then we rebase this PR on top of the latest MK3 branch, test this PR again, then merge it. Does this sound good? |
druk - jako proces wydruk - jako produkt wyładuj (zamiast rozładuj) kanał (nie slot) katalog (nie folder) podręcznik (nie instrukcja) firmware (krótsze; nie oprogramowanie układowe) bazowanie (nie zerowanie bo zerowanie może wiele rzeczy oznaczać) nieudane (zamiast nie powiódł się bo krótsze)
8798490
to
37af110
Compare
Rebased and fixed the conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed internally and approved
@arekm Bardzo dziękuję za ten pull request
Bed / hotend strings not marked as translatable at 3:28 ? "Najpierw" twice at beginning of two sentences, one after another. Hmm, could change one occurrence to something else to not repeat it that often (3:13 and 3:17). |
PL diacritics and some unification. Lengths have changed in few cases.
druk - jako proces
wydruk - jako produkt
wyładuj (zamiast rozładuj)
kanał (nie slot)
katalog (nie folder)
podręcznik (nie instrukcja)
firmware (krótsze; nie oprogramowanie układowe)
bazowanie (nie zerowanie bo zerowanie może wiele rzeczy oznaczać)
nieudane (zamiast nie powiódł się bo krótsze)