feat(apps/phone): when creating a conversation, redirect to it if exists #1066

GiroudMathias · 2023-08-30T20:52:01Z

Pull Request Description

Somes changes and optimisations:

When creating a conversation, redirect to it if exists
Message's search in name and number

Pull Request Checklist:

Have you followed the guidelines in our Contributing document and Code of Conduct?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you built and tested NPWD in-game after the relevant change?

GiroudMathias

On message, search user with number or contact name

itschip · 2023-09-20T17:04:23Z

apps/game/server/messages/messages.service.ts

@@ -64,6 +64,7 @@ class _MessagesService {
        return resp({
          status: 'error',
          errorMsg: 'MESSAGES.FEEDBACK.MESSAGE_CONVERSATION_DUPLICATE',
+          data: { id: await this.messagesDB.getConversationId(conversationList) }


Please follow the pattern and call async function outside of the resp function

GiroudMathias added 3 commits August 30, 2023 22:51

feat(apps/phone): when creating a conversation, redirect to it if exists

a6932a2

fix: (apps/phone): Message's search in name and number

c15490f

Merge branch 'master' into master

4105857

GiroudMathias commented Sep 20, 2023

View reviewed changes

itschip requested changes Sep 20, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(apps/phone): when creating a conversation, redirect to it if exists #1066

feat(apps/phone): when creating a conversation, redirect to it if exists #1066

GiroudMathias commented Aug 30, 2023 •

edited

Loading

GiroudMathias left a comment

itschip Sep 20, 2023

feat(apps/phone): when creating a conversation, redirect to it if exists #1066

Are you sure you want to change the base?

feat(apps/phone): when creating a conversation, redirect to it if exists #1066

Conversation

GiroudMathias commented Aug 30, 2023 • edited Loading

GiroudMathias left a comment

Choose a reason for hiding this comment

itschip Sep 20, 2023

Choose a reason for hiding this comment

GiroudMathias commented Aug 30, 2023 •

edited

Loading