endline validation #649
Merged
endline validation #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikh360
reviewed
Jul 31, 2023
yal/main.py
Outdated
| Validates survey keywords from RapidPro | ||
| """ | ||
|
|
||
| GENERIC_ERRORS = ( |
There was a problem hiding this comment.
Can't we import these from the other place they are defined?
There was a problem hiding this comment.
The wording is different
erikh360
reviewed
Aug 1, 2023
yal/main.py
Outdated
Comment on lines
865
to
866
| async def state_survey_validation(self): | ||
| """ |
There was a problem hiding this comment.
Is main.py the right place for this state? It's very survey specific so maybe it should live there?
erikh360
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.