Harmonize blank option #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frykten
commented
Oct 14, 2021
Comment on lines
-8
to
-10
| if (options.allowBlank) { | ||
| options.allowNone = true; | ||
| } |
There was a problem hiding this comment.
I removed this one as it is not useful: isEmpty is basically isNone but with a larger scope, hence allowBlank has the same scope as allowNone but larger 🤷 (cf.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is linked to my proposal in #317 .
So I changed the allowBlank's check for the date validator to Ember's util
isEmpty, as per the ones in the ember-validators (and therefore the ones in the other validators of this addon, since all but date use ember-validators).However, while doing that, I saw that ember-validators does not use isEmpty for their dates (exceptionally) and instead make a custom check to only nullish values and empty strings (cf.). Maybe you would copy that, instead? I'm opening an issue on their side to ask them why this inconsistency.
Also, I updated the tests of the other addons to harmonize their checks and reflect the behaviours.