build: bump k256 to 0.13.2 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaunov
reviewed
Nov 18, 2023
0xmad
reviewed
Nov 19, 2023
rust-k256/src/lib.rs
Outdated
| @@ -106,7 +105,7 @@ impl PlumeSignature<'_> { | |||
| // don't forget to check `c` is `Output<Sha256>` in the #API | |||
| let c = Output::<Sha256>::from_slice(self.c); | |||
| // TODO should we allow `c` input greater than BaseField::MODULUS? | |||
| let c_scalar = &Scalar::from_uint_reduced(U256::from_be_byte_array(c.to_owned())); | |||
| let c_scalar = &Scalar::reduce_nonzero(U256::from_be_byte_array(c.to_owned())); | |||
There was a problem hiding this comment.
I think you need to run cargo fmt and cargo clippy.
|
@RajeshRk18 please rebase with current main branch so PR has only commits related to this issue. |
RajeshRk18
force-pushed
the
bump-k256
branch
from
b2ad135
to
ac8969e
Compare
skaunov
previously requested changes
Nov 29, 2023
skaunov
dismissed
their stale review
@Divide-By-0: "look i just want to merge something that works and move on for this, it sorta is an irrelevant thing since that value is almost never 0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70