Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the list command to display local subtemplates. #147

Merged
merged 4 commits into from
Jun 25, 2015
Merged

Allow the list command to display local subtemplates. #147

merged 4 commits into from
Jun 25, 2015

Conversation

aalmiray
Copy link
Contributor

Listing subtemplates is an optional operation. It's only triggered if
the current directory has a .lazybones directory.

Related to #142.

@aalmiray
Allow the list command to display local subtemplates.
a3a4b76 
Listing subtemplates is an optional operation. It's only triggered if
the current directory has a .lazybones directory.
@pledbrook
Copy link
Owner

Thanks for this. Unfortunately I can't merge without a corresponding functional test. I'll try to create one soon.

This was referenced Mar 3, 2015
Open
Open
@pledbrook
Copy link
Owner

I don't think there can be consistency and useful output from the list command until an intermediate Lazybones server is created. Bintray doesn't provide sufficient information for unauthenticated clients and I don't see how we can safely provide auth credentials for the command line app (without inconveniencing the user unduly).

@pledbrook
Copy link
Owner

I've raised #156 to cover the case of including more information in the output. For this issue, I plan to add a --subs option to limit output to sub templates only. I might add an --all option to force display of everything: remote, cached, and sub templates.

@pledbrook pledbrook merged commit fb3b072 into pledbrook:master Jun 25, 2015
pledbrook added a commit that referenced this pull request Jun 25, 2015
@pledbrook
Add --subs option to list command.
dac558a 
Further work to #147. There is now a `--subs` option on the `list` command that
only displays the subtemplates installed in the current Lazybones-created
project. The command errors out if there is no .lazybones directory in the
current working directory.

I also modified the `--cached` option to group templates by name, so that all
available versions are listed as one entry.
@pledbrook
Copy link
Owner

Do you mind building from source and testing this out? You could also just review ListFunctionalSpec, but it's not quite the same. I didn't bother adding --all at this point, since that just feels like an overload of information. If it's explicitly requested, I might do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalmiray @pledbrook