Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service default/explicit endpoint definition #4063

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Fix service default/explicit endpoint definition #4063

wants to merge 26 commits into from

Conversation

flovntp
Copy link
Contributor

@flovntp flovntp commented Jun 12, 2024 •
edited
Loading

  • to be fixed: lots of Legacy relationships definition here sites/upsun/src/registry/images/examples/commented/*

Why

Closes #{ISSUE_NUMBER}

What's changed

@flovntp flovntp added the WIP label Jun 12, 2024
@flovntp flovntp changed the title WIP Fix service def expl WIP Fix service default/explicit endpoint definition Jun 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

Your Platform.sh environment has successfully deployed. 🚀

See the changed pages:

Platform.sh docs
Upsun docs

@flovntp flovntp removed the WIP label Jun 18, 2024
@flovntp flovntp changed the title WIP Fix service default/explicit endpoint definition Fix service default/explicit endpoint definition Jun 18, 2024
@AnouckColson AnouckColson self-requested a review June 18, 2024 09:46
flovntp and others added 6 commits August 7, 2024 17:08
@flovntp
remove service def from relationship def on Upsun side
775472f
@flovntp
align with .platform/applications.yaml config def
453bbc9
@flovntp
indentation for snippets on Upsun
56684c5
@flovntp
P.sh remove promotion of .platform/applications.yaml --> .platform.ap…
4ff0653 
…p.yaml
@flovntp
indentation of Yaml snippets with 2 spaces (#4145)
9e08dc3 
* indentation of Yaml snippets with 2 spaces

* indentation on Upsun from 4 to 2 spaces on YAML snippets

* consistency in the file + small issue

* change app to myapp on platform

* change app to myapp on upsun
@chadwcarlson
Merge branch 'main' into fix-service-def-expl
172b77b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnouckColson AnouckColson AnouckColson approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@flovntp flovntp

Labels
do not merge markdown/prose on-deck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flovntp @AnouckColson @chadwcarlson @platformsh-devrel @thomasdiluccio