Skip to content

Commit

Permalink
Merge pull request #546 from plaid/develop
Browse files Browse the repository at this point in the history
  • Loading branch information
dtroupe-plaid committed Aug 9, 2023
2 parents 74942ca + ee9cc39 commit 0d93f90
Show file tree
Hide file tree
Showing 17 changed files with 15,566 additions and 15,472 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_test_ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
${{ runner.os }}-pods-
- name: Install pod dependencies
run: cd example/ios && bundle install && bundle exec pod install && cd ..
run: cd example/ios && bundle install && bundle exec pod update && cd ../

- name: Install the Apple certificate and provisioning profile
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Pull Request into Master or Develop

on:
# Triggers the workflow on a pull request pointed at develop or master.
# Triggers the workflow on a pull request pointed at develop.
pull_request:
branches:
- "develop"
Expand Down
6 changes: 5 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,8 @@ buck-out/
*.keystore

# React Native ts
dist/
dist/

.vscode
example/.yalc
example/yalc.lock
46 changes: 46 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,51 @@
# RELEASES

## LinkKit V10.4.0 — 2023-08-08

### React Native

#### Requirements

| Name | Version |
|------|---------|
| React Native | >= [66.0](https://reactnative.dev/blog/2021/10/01/version-066) |

#### Changes

- Update iOS Native SDK.
- Add support to present Link full screen. `PlaidLinkProps` not supports passing a `LinkIOSPresentationStyle`. Pass `FULL_SCREEN` to present Link full screen instead of as a modal. For more information checkout the [pull-request](https://github.com/plaid/react-native-plaid-link-sdk/pull/543).

### Android

[Android SDK 3.13.2](https://github.com/plaid/plaid-link-android/releases/tag/v3.13.2)

#### Requirements

| Name | Version |
|------|---------|
| Android Studio | 4.0+ |


#### Changes

- Changed LinkRedirectActivity theme from Material to MaterialComponents.

### iOS

[iOS SDK 4.5.1](https://github.com/plaid/plaid-link-ios/releases/tag/4.5.1)

#### Requirements

| Name | Version |
|------|---------|
| Xcode | >= 14.0 |
| iOS | >= 11.0 |

#### Changes

- Add identityVerificationPendingReviewSession event name.
- Bug fixes.

## LinkKit V10.4.0 — 2023-06-13

### React Native
Expand Down
12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,23 @@ AutoLinking should handle all of the Android setup.

```javascript
import { Text } from 'react-native';
import { PlaidLink, LinkSuccess, LinkExit } from 'react-native-plaid-link-sdk';
import { PlaidLink, LinkSuccess, LinkExit, LinkLogLevel, LinkIOSPresentationStyle } from 'react-native-plaid-link-sdk';

const MyPlaidComponent = () => {
return (
<PlaidLink
tokenConfig={{
token: "#GENERATED_LINK_TOKEN#",
// OPTIONAL - log level.
logLevel: LinkLogLevel.ERROR,
// OPTIONAL - Hides native activity indicator if true.
noLoadingState: false,
}}
onSuccess={(success: LinkSuccess) => { console.log(success) }}
onExit={(exit: LinkExit) => { console.log(exit) }}
// OPTIONAL - MODAL or FULL_SCREEEN presentation on iOS. Defaults to MODAL.
// UI is always presented in full screen on Android.
iOSPresentationStyle={LinkIOSPresentationStyle.MODAL}
>
<Text>Add Account</Text>
</PlaidLink>
Expand Down Expand Up @@ -138,7 +145,8 @@ You can also use the `usePlaidEmitter` hook in react functional components:

| Plaid SDK Version | Min React Native Version | Android SDK | Android Min Version | Android Compile Version| iOS SDK | iOS Min Version | Status |
|-------------------|--------------------------|-------------|---------------------|------------------------|---------|-----------------|-------------------------------|
| 10.4.0 | >= 0.66.0 | [3.12.2+] | 21 | 33 | >=4.4.0 | 11.0 | Active, supports Xcode 14 |
| 10.5.0 | >= 0.66.0 | [3.12.2+] | 21 | 33 | >=4.5.1 | 11.0 | Active, supports Xcode 14 |
| 10.4.0 | >= 0.66.0 | [3.12.2+] | 21 | 33 | >=4.4.0 | 11.0 | Deprecated, supports Xcode 14 |
| 10.3.0 | >= 0.66.0 | [3.12.1+] | 21 | 33 | >=4.3.0 | 11.0 | Deprecated, supports Xcode 14 |
| 10.2.0 | >= 0.66.0 | [3.12.0+] | 21 | 33 | >=4.3.0 | 11.0 | Deprecated, supports Xcode 14 |
| 10.1.0 | >= 0.66.0 | [3.11.0+] | 21 | 33 | >=4.2.0 | 11.0 | Deprecated, supports Xcode 14 |
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<application>
<meta-data
android:name="com.plaid.link.react_native"
android:value="10.4.0" />
android:value="10.5.0" />
</application>

</manifest>
7 changes: 6 additions & 1 deletion example/PlaidEventContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react';
import {TextInput, Text, TouchableOpacity, useColorScheme} from 'react-native';
import {Colors} from 'react-native/Libraries/NewAppScreen';
import {styles} from './Styles';

import {
LinkExit,
LinkEvent,
Expand All @@ -11,6 +12,7 @@ import {
dismissLink,
PlaidLinkProps,
usePlaidEmitter,
LinkIOSPresentationStyle,
} from 'react-native-plaid-link-sdk';

// Create PlaidLinkProps from the provided token string.
Expand All @@ -19,7 +21,8 @@ function makeLinkTokenProps(token: string): PlaidLinkProps {
tokenConfig: {
token: token,
logLevel: LinkLogLevel.ERROR,
noLoadingState: false, // Hides native activity indicator if true.
// Hides native activity indicator if true.
noLoadingState: false,
},
onSuccess: (success: LinkSuccess) => {
// User was able to successfully link their account.
Expand All @@ -31,6 +34,8 @@ function makeLinkTokenProps(token: string): PlaidLinkProps {
console.log('Exit: ', linkExit);
dismissLink();
},
// MODAL or FULL_SCREEEN presentation on iOS. Defaults to MODAL.
iOSPresentationStyle: LinkIOSPresentationStyle.MODAL,
};
}

Expand Down
Binary file modified example/ios/main.jsbundle
Binary file not shown.
2 changes: 1 addition & 1 deletion example/ios/plaidRNDemoTests/PlaidRNDemoTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ final class PlaidRNDemoTests: XCTestCase {
func testVersion() {
let version = LinkKitVersion

XCTAssertEqual(version, "4.4.0")
XCTAssertEqual(version, "4.5.1")
}

func testPlaidCredentialsExist() {
Expand Down
5 changes: 3 additions & 2 deletions example/ios/plaidRNDemoUITests/PlaidRNDemoUITests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,23 @@ final class PlaidRNDemoUITests: XCTestCase {
var webview: XCUIElement { app.webViews.firstMatch }

/// Default amount of time to wait for elements before throwing an error.
let defaultTimeout: TimeInterval = 15.0
let defaultTimeout: TimeInterval = 25.0

private(set) var clientID: String = ""
private(set) var apiSecret: String = ""

func enterToken(token: String) throws {
let tokenTextField = app.otherElements["link-sandbox-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"]
let openElements = app.otherElements.matching(identifier: "OPEN LINK")
let _ = tokenTextField.waitForExistence(timeout: defaultTimeout * 2)
let _ = tokenTextField.waitForExistence(timeout: defaultTimeout)

guard tokenTextField.exists else {
throw UITestError.elementDoesNotExist(message: "Token TextField does not exist.")
}

UIPasteboard.general.string = token
tokenTextField.doubleTap()
sleep(2)
tokenTextField.doubleTap()

// Typing in the link token caused issues where it would type "lnk-token-xxxx" which resulted
Expand Down
Loading

0 comments on commit 0d93f90

Please sign in to comment.