Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring, add types #24

Merged
merged 5 commits into from
Oct 4, 2023
Merged

refactoring, add types #24

merged 5 commits into from
Oct 4, 2023

Conversation

issamansur
Copy link
Contributor

@issamansur issamansur commented Sep 26, 2023 •
edited
Loading

fix #19
Please, check all very carefully

@issamansur issamansur mentioned this pull request Sep 26, 2023
Closed
pjcalvo
pjcalvo requested changes Sep 26, 2023
View reviewed changes
locust_influxdb_listener/__init__.py Outdated Show resolved Hide resolved
locust_influxdb_listener/__init__.py Outdated Show resolved Hide resolved
locust_influxdb_listener/__init__.py Outdated Show resolved Hide resolved
@issamansur
Copy link
Contributor Author

Done!

@issamansur
Copy link
Contributor Author

What can we use? Response or HTTPConnectionPool?

pjcalvo
pjcalvo requested changes Sep 26, 2023
View reviewed changes
locust_influxdb_listener/__init__.py Outdated Show resolved Hide resolved
@issamansur
Copy link
Contributor Author

Done!

pjcalvo
pjcalvo requested changes Sep 26, 2023
View reviewed changes
locust_influxdb_listener/__init__.py Outdated Show resolved Hide resolved
@issamansur
Copy link
Contributor Author

Done! I would be glad to hear any recommendations on pool requests from you)

@issamansur
Copy link
Contributor Author

Build failed on python version 3.11 because type of variable cannot defined by symbol |, for example: int | str.
What can I do with this?

@pjcalvo
Copy link
Owner

pjcalvo commented Sep 27, 2023

Build failed on python version 3.11 because type of variable cannot defined by symbol |, for example: int | str. What can I do with this?

Please use union which is supported in python 3.9

from typing import Union

# Define a variable that can be either int or str
variable: Union[int, str]

@issamansur
Copy link
Contributor Author

Done!

@issamansur
Copy link
Contributor Author

@pjcalvo meow)

@pjcalvo pjcalvo merged commit f4af465 into pjcalvo:main Oct 4, 2023
3 checks passed
@issamansur issamansur deleted the add-typings branch October 4, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjcalvo pjcalvo pjcalvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python typings
2 participants
@issamansur @pjcalvo