Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar/AvatarGroup: VR Implementation Changes #3765

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

se7en-illa
Copy link
Contributor

Pull Request Instructions

Thanks for creating a PR! 🎉

  • Please follow this template and delete items/sections that are not relevant to your changes, including these instructions.
  • Make sure your PR title matches our format: {ComponentName}: Description (mention platform if relevant). If there are changes to multiple components, use {ComponentName}, {OtherComponentName}: Description (mention platform if relevant).
  • Each PR needs a label indicating which semantic version should be applied:
    • Major: Breaking changes to existing components (e.g. removing a prop, removing a prop value, removing a component).
    • Minor: New components, non-breaking changes to existing components (e.g. adding a new prop, adding a new prop value).
    • Patch: Bugfixes, internal refactors that don't change the component's API, most dependency upgrades, all docs updates.
  • If you're updating a dependency, please also include the dependencies label.

Pull Request Template

Summary

What changed?

At a high level, what changes does this PR introduce?

Why?

What is the purpose of this PR? Please include the context around these changes for Future Us. In addition to what is changing, we need to know why these changes are needed. Imagine someone is looking at these changes a year from now and needs to know why they were made.

Links

  • Jira
  • [TDD](link to Paper doc)
  • [Figma](link to Figma file)

Checklist

  • Added unit tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

@se7en-illa se7en-illa requested a review from a team as a code owner September 19, 2024 15:13
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b24e2a4
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/66ecc4ecc1ff200008f6a501
😎 Deploy Preview https://deploy-preview-3765--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@se7en-illa se7en-illa marked this pull request as draft September 19, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant