Presentation detail link proposal #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,6 +149,12 @@ def notification_email_context(self): | |||
| "kind": self.kind.name, | |||
| } | |||
|
|
|||
| def save(self, *args, **kwargs): | |||
There was a problem hiding this comment.
#110 is for a slot name. here is for a proposal with same way.
|
@jtauber was there a specific reason for the copying over of these fields? Could they ever change on one but not the other? If not, I think this is a decent change. |
|
@jtauber I've tested this code on my project and it does not use |
miurahr
force-pushed
the
presentation_detail_link_proposal
branch
from
617b298
to
cad6d1e
Compare
|
rebased. |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
presentation_detail_link_proposal
branch
from
cad6d1e
to
8aa5abb
Compare
|
This PR make a bug to reverse-reference from Speaker to Presentation. Because it drop speaker field from Presentation and add a function to refer Proposal.speaker. This cause a problem. |
|
I'd like to mark it Invalid and close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #91