Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use InputBagTypeSpecifyingExtension on true context. #409

Merged

Conversation

VincentLanglet
Copy link
Contributor

The InputBag::has method rely on array_key_exists

see
https://github.com/symfony/symfony/blob/e7589c18012314ef262f040357b832a264b2a6eb/src/Symfony/Component/HttpFoundation/ParameterBag.php#L86-L89

So the following code is valid

$inputBag->set('foo', null);
$inputBag->has('foo'); // true
$inputBag->get('foo'); // null

:/

@ondrejmirtes ondrejmirtes merged commit f7d5782 into phpstan:1.4.x Sep 26, 2024
41 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants