Skip to content

Commit

Permalink
add Common code components to binder through InstanceRegistry, phetsi…
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Jul 18, 2019
1 parent 29bc7fc commit 7b85d2f
Show file tree
Hide file tree
Showing 4 changed files with 54 additions and 50 deletions.
34 changes: 19 additions & 15 deletions js/Carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,24 @@ define( function( require ) {
'use strict';

// modules
var Animation = require( 'TWIXT/Animation' );
var CarouselButton = require( 'SUN/buttons/CarouselButton' );
var Dimension2 = require( 'DOT/Dimension2' );
var Easing = require( 'TWIXT/Easing' );
var HSeparator = require( 'SUN/HSeparator' );
var inherit = require( 'PHET_CORE/inherit' );
var Node = require( 'SCENERY/nodes/Node' );
var Property = require( 'AXON/Property' );
var Rectangle = require( 'SCENERY/nodes/Rectangle' );
var Shape = require( 'KITE/Shape' );
var sun = require( 'SUN/sun' );
var timer = require( 'AXON/timer' );
var Util = require( 'DOT/Util' );
var VSeparator = require( 'SUN/VSeparator' );
const Animation = require( 'TWIXT/Animation' );
const CarouselButton = require( 'SUN/buttons/CarouselButton' );
const Dimension2 = require( 'DOT/Dimension2' );
const Easing = require( 'TWIXT/Easing' );
const HSeparator = require( 'SUN/HSeparator' );
const inherit = require( 'PHET_CORE/inherit' );
const InstanceRegistry = require( 'PHET_CORE/documentation/InstanceRegistry' );
const Node = require( 'SCENERY/nodes/Node' );
const Property = require( 'AXON/Property' );
const Rectangle = require( 'SCENERY/nodes/Rectangle' );
const Shape = require( 'KITE/Shape' );
const sun = require( 'SUN/sun' );
const timer = require( 'AXON/timer' );
const Util = require( 'DOT/Util' );
const VSeparator = require( 'SUN/VSeparator' );

// constants
var DEFAULT_OPTIONS = {
const DEFAULT_OPTIONS = {

// container
orientation: 'horizontal', // {string} 'horizontal'|'vertical'
Expand Down Expand Up @@ -330,6 +331,9 @@ define( function( require ) {
};

Node.call( this, options );

// support for binder documentation, stripped out in builds and only runs when ?binder is specified
assert && phet.chipper.queryParameters.binder && InstanceRegistry.registerDataURL( 'sun', 'Carousel', this );
}

sun.register( 'Carousel', Carousel );
Expand Down
8 changes: 4 additions & 4 deletions js/HSlider.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ define( function( require ) {
'use strict';

// modules
var inherit = require( 'PHET_CORE/inherit' );
var InstanceRegistry = require( 'PHET_CORE/documentation/InstanceRegistry' );
var Slider = require( 'SUN/Slider' );
var sun = require( 'SUN/sun' );
const inherit = require( 'PHET_CORE/inherit' );
const InstanceRegistry = require( 'PHET_CORE/documentation/InstanceRegistry' );
const Slider = require( 'SUN/Slider' );
const sun = require( 'SUN/sun' );

/**
* @param {Property.<number>} valueProperty
Expand Down
52 changes: 24 additions & 28 deletions js/Slider.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,32 +12,31 @@ define( function( require ) {
'use strict';

// modules
var AccessibleSlider = require( 'SUN/accessibility/AccessibleSlider' );
var assertMutuallyExclusiveOptions = require( 'PHET_CORE/assertMutuallyExclusiveOptions' );
var BooleanProperty = require( 'AXON/BooleanProperty' );
var DefaultSliderTrack = require( 'SUN/DefaultSliderTrack' );
var Dimension2 = require( 'DOT/Dimension2' );
var FocusHighlightFromNode = require( 'SCENERY/accessibility/FocusHighlightFromNode' );
var inherit = require( 'PHET_CORE/inherit' );
var InstanceRegistry = require( 'PHET_CORE/documentation/InstanceRegistry' );
var Node = require( 'SCENERY/nodes/Node' );
var Path = require( 'SCENERY/nodes/Path' );
var PhetioObject = require( 'TANDEM/PhetioObject' );
var Property = require( 'AXON/Property' );
var PropertyIO = require( 'AXON/PropertyIO' );
var Range = require( 'DOT/Range' );
var RangeIO = require( 'DOT/RangeIO' );
var Shape = require( 'KITE/Shape' );
var SimpleDragHandler = require( 'SCENERY/input/SimpleDragHandler' );
var SliderIO = require( 'SUN/SliderIO' );
var SliderThumb = require( 'SUN/SliderThumb' );
var sun = require( 'SUN/sun' );
var SunConstants = require( 'SUN/SunConstants' );
var Tandem = require( 'TANDEM/Tandem' );
var Util = require( 'DOT/Util' );
const AccessibleSlider = require( 'SUN/accessibility/AccessibleSlider' );
const assertMutuallyExclusiveOptions = require( 'PHET_CORE/assertMutuallyExclusiveOptions' );
const BooleanProperty = require( 'AXON/BooleanProperty' );
const DefaultSliderTrack = require( 'SUN/DefaultSliderTrack' );
const Dimension2 = require( 'DOT/Dimension2' );
const FocusHighlightFromNode = require( 'SCENERY/accessibility/FocusHighlightFromNode' );
const inherit = require( 'PHET_CORE/inherit' );
const Node = require( 'SCENERY/nodes/Node' );
const Path = require( 'SCENERY/nodes/Path' );
const PhetioObject = require( 'TANDEM/PhetioObject' );
const Property = require( 'AXON/Property' );
const PropertyIO = require( 'AXON/PropertyIO' );
const Range = require( 'DOT/Range' );
const RangeIO = require( 'DOT/RangeIO' );
const Shape = require( 'KITE/Shape' );
const SimpleDragHandler = require( 'SCENERY/input/SimpleDragHandler' );
const SliderIO = require( 'SUN/SliderIO' );
const SliderThumb = require( 'SUN/SliderThumb' );
const sun = require( 'SUN/sun' );
const SunConstants = require( 'SUN/SunConstants' );
const Tandem = require( 'TANDEM/Tandem' );
const Util = require( 'DOT/Util' );

// constants
var VERTICAL_ROTATION = -Math.PI / 2;
const VERTICAL_ROTATION = -Math.PI / 2;

/**
* @param {Property.<number>} valueProperty
Expand Down Expand Up @@ -351,10 +350,7 @@ define( function( require ) {
this.addLinkedElement( options.phetioLinkedProperty || valueProperty, {
tandem: options.tandem.createTandem( 'valueProperty' )
} );

// support for binder documentation, stripped out in builds and only runs when ?binder is specified
assert && phet.chipper.queryParameters.binder && InstanceRegistry.registerDataURL( 'sun', 'Slider', this );
}
}

sun.register( 'Slider', Slider );

Expand Down
10 changes: 7 additions & 3 deletions js/VSlider.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@ define( function( require ) {
'use strict';

// modules
var inherit = require( 'PHET_CORE/inherit' );
var Slider = require( 'SUN/Slider' );
var sun = require( 'SUN/sun' );
const inherit = require( 'PHET_CORE/inherit' );
const InstanceRegistry = require( 'PHET_CORE/documentation/InstanceRegistry' );
const Slider = require( 'SUN/Slider' );
const sun = require( 'SUN/sun' );

/**
* @param {Property.<number>} valueProperty
Expand All @@ -27,6 +28,9 @@ define( function( require ) {
Slider.call( this, valueProperty, range, _.extend( {
orientation: 'vertical'
}, options ) );

// support for binder documentation, stripped out in builds and only runs when ?binder is specified
assert && phet.chipper.queryParameters.binder && InstanceRegistry.registerDataURL( 'sun', 'VSlider', this );
}

sun.register( 'VSlider', VSlider );
Expand Down

0 comments on commit 7b85d2f

Please sign in to comment.